Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: locks key in point get executor for pessimistic transaction #10976

Merged
merged 2 commits into from
Jul 1, 2019
Merged

executor: locks key in point get executor for pessimistic transaction #10976

merged 2 commits into from
Jul 1, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Jun 28, 2019

Cherry-pick #10972
No conflict

@coocood coocood requested a review from tiancaiamao June 28, 2019 06:14
jackysp
jackysp reviewed Jun 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2019
@coocood
Copy link
Member Author

coocood commented Jun 28, 2019

/run-all-tests

lysu
lysu approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lysu
lysu previously requested changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending for release-tags

@coocood coocood dismissed lysu’s stale review June 30, 2019 06:07

release is tagged

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 30, 2019
jackysp
jackysp approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit d8ffce9 into pingcap:release-3.0 Jul 1, 2019
@coocood coocood deleted the point-get-lock-3.0 branch July 1, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@lysu lysu lysu left review comments

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coocood @lysu @jackysp